Add Gyro2V2 pool = Gyro 2CLP supporting rate scaling #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @joshguha , here's my code for the 2CLP rate scaling.
Would be good if you could give it a thorough review, especially if I got the rate fetching right. Not super sure about that, I mostly copied the gyroEV2Pool code.
Can you also check the small TODO in src/index.ts, I'm not sure what these exports are even for?
Tests are not done yet. TODO for Thu. Oh, and we don't have a pool live yet so we can't do an integration test.