Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing for glob, when only one file is returned. #242

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

PierrePaul
Copy link
Contributor

@PierrePaul PierrePaul commented Jun 27, 2024

Issue being resolved: #241

Solution description

Return the Path of the file found instead of returning the file pattern.

Potential impacts

I have run the test without failures, but I don't see any tests about the glob feature. I tried to add one.

Steps to test

Happy path to test implemented scenario

PR Tasks

  • PR reference added to issue
  • README updated
  • Unit tests added/updated

@acuanico-tr-galt acuanico-tr-galt self-requested a review July 5, 2024 12:30
@PierrePaul
Copy link
Contributor Author

Thanks for the approval @acuanico-tr-galt !
Just so you know, I'm not authorized to merge, even if I have approval :)

@PierrePaul
Copy link
Contributor Author

Tagging @acuanico-tr-galt for more visibility :)

Copy link
Collaborator

@acuanico-tr-galt acuanico-tr-galt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience with this late review. Looks good to me! Approved for merge.

@acuanico-tr-galt acuanico-tr-galt merged commit 3b1ffbb into gurock:main Aug 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use glob with junit, if there's only one file returned by the glob pattern
2 participants