Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to upgrading to Gulp 4 article #1588

Merged
merged 1 commit into from
Apr 5, 2016
Merged

Add link to upgrading to Gulp 4 article #1588

merged 1 commit into from
Apr 5, 2016

Conversation

mikestreety
Copy link
Contributor

No description provided.

@phated
Copy link
Member

phated commented Apr 4, 2016

Corrections on the article:

  1. Don't install gulpjs/gulp-cli#4.0 - just install the latest gulp-cli from npm (the 4.0 branch will be removed soon)
  2. The gulp-cli version should be 1.2.1 when gulp -v is run
  3. npm knows how to handle packages that look like npm install gulpjs/gulp#4.0 so you don't need the git+https, etc.
  4. package.json misspelled
  5. Returning a stream, promise, event emitter, child process or observable is supported, not just stream. The callback is supported incase you can't return any of those.
  6. Don't execute del sync, it returns a promise, so just return that statement. return del([])

If you make those changes, I'll merge this. Thanks.

@mikestreety
Copy link
Contributor Author

Wow, thanks for the suggestions 😄 will update and let you know!

@mikestreety
Copy link
Contributor Author

Hi @phated - i've updated the blog post with your changes. Thanks for the feedback - much appreciated!

@phated
Copy link
Member

phated commented Apr 5, 2016

@mikestreety sorry about not being clear about the gulp-cli module. It is actually published on npm (https://www.npmjs.com/package/gulp-cli) so you can just install it with npm install -g gulp-cli - no need to fetch it from github

@mikestreety
Copy link
Contributor Author

Ah yes, got you. Updated thanks!

@phated
Copy link
Member

phated commented Apr 5, 2016

Excellent! Thanks!

@phated phated merged commit 0bad3af into gulpjs:4.0 Apr 5, 2016
@zyf0330
Copy link

zyf0330 commented Apr 18, 2016

Hello!
I have done everything, including gulp-cli@latest and gulp@3.9.1, but I get an error showing "gulp.parallel is not a function". What else do I need to do?

@mikestreety
Copy link
Contributor Author

Hi @zyf0330

Can you cd to your project and run gulp -v - are you getting the correct versions?

Also, would you mind sending your gulpfile?

@zyf0330
Copy link

zyf0330 commented Apr 18, 2016

Thank you! @mikestreety
gulp -v show

CLI version 1.2.1
Local version 3.9.1

This is my gulpfile, I delete some code and these code will cause the same result.

var fs = require('fs');
var _path = require('path');
var gulp = require('gulp')
var newer = require('gulp-newer');
var modify = require('gulp-modify');
var uglify = require('gulp-uglify')
var cleanCSS = require('gulp-clean-css');
var htmlmin = require('gulp-htmlmin');
var imagemin  = require('gulp-imagemin');

gulp.task('default', gulp.parallel(function () {
    console.log('finish')
}))

@callumacrae
Copy link
Member

Please can you take this to the comments of the article or to Stack Overflow? This isn't really the place for support.

Thanks! 🎉

@mikestreety
Copy link
Contributor Author

mikestreety commented Apr 18, 2016

Sorry Callum!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants