Use 'node-exit' for better windows support

[Bartvds]

Node.js has a known issue on windows with truncated stdout on process exit.

I have this now when using gulp within WebStorm.

The grunt team made a nice hack for it: I propose to use this in gulp: node-exit

[sindresorhus]

strongly 👎, it destroys process.on('exit') for any loaded module.
Eg: https://github.com/sindresorhus/time-grunt/blob/master/time-grunt.js#L18

[Bartvds]

Yea, it is not ideal at all.

But stdout on windows is truncating (same as in the grunt issue), so this will come back again if gulp gets some more varied users (the issue was hot on grunt).

It is time it is fixed upstream in node itself. Bug is open for 2 years now.. 😞

[phated]

Gulp doesn't have a goal to support Windows. I think this should be closed.

[yocontra]

@phated to an extent - if an easy fix can be put in place that doesn't penalize others I would do it. node-exit breaks things on other OSes though apparently

[Bartvds]

Gulp doesn't have a goal to support Windows.

I can live without node-exit, it is a huge hack after all. With some luck this gets fixed upstream before 0.12.

But I'm sure this is a misunderstanding that Gulp doesn't support Windows? If you look at the known issue I mentioned you can see windows support in node.js is a real thing. Grunt can do it so I'd expect Gulp to do so too.

[thasmo]

Huh, why wouldn't gulp support Windows?

[phated]

Calm down @Bartvds and @thasmo. As @contra said, Gulp will take patches for windows as long as they don't cause problems on other OSes. @robrich, a core contributor, uses windows, so it will continue to work for the foreseeable future. I was just stating that Gulp hasn't made it a goal to work 100% (like truncating stdout on exit) on windows over other OSes. This issue in particular should be fixed upstream.

Sorry for the confusion.

[robrich]

I agree. Though Windows support is near and dear to me (I think gulp fills the void left by nant and not filled by MSBuild) making everyone suffer isn't a good move. Let's push to have this resolved in node, not hacked around in gulp.

[sindresorhus]

making everyone suffer isn't a good move

well, it's just putting the suffering on us developers having to support Windows :p

[Bartvds]

Cool, we'll see if node fixes this (one day..).

Re windows: if people not reinvent system stuff but use modules then things
work fine.. mostly :D

2014/1/21 Sindre Sorhus notifications@github.com

making everyone suffer isn't a good move

well, it's just putting the suffering on us developers having to support
Windows :p

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/172#issuecomment-32967986
.