Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed status bar resize on Windows; not in cmd.exe #685

Merged
merged 1 commit into from
Jun 13, 2020
Merged

fixed status bar resize on Windows; not in cmd.exe #685

merged 1 commit into from
Jun 13, 2020

Conversation

tig
Copy link
Collaborator

@tig tig commented Jun 13, 2020

With this PR, the StatusBar shows correctly when a Windows console is resized smaller.

Note this still is broken in cmd.exe and will probably always be. But in Windows Terminal and ConEmu it now works as expected.

Closes #357.

@tig tig merged commit cd03cdc into gui-cs:master Jun 13, 2020
@tig tig deleted the statusbar_resize branch June 13, 2020 15:25
@BDisp
Copy link
Collaborator

BDisp commented Jun 13, 2020

@tig do you know why the mouse don't work on the Windows Terminal?

@tig
Copy link
Collaborator Author

tig commented Jun 13, 2020

@tig do you know why the mouse don't work on the Windows Terminal?

I do not know the details, but I understand it is due to bugs in Windows Terminal. Tracking here: #332

Note the mouse doesn't work well in conemu either.

@BDisp
Copy link
Collaborator

BDisp commented Jun 13, 2020

@tig this is causing an error in the TopologicalSort method after you exit a scenario.

System.InvalidOperationException: 'TopologicalSort (for Pos/Dim) cannot find Toplevel()({X=0,Y=0,Width=120,Height=30}). Did you forget to add it to Toplevel()({X=0,Y=0,Width=120,Height=30})?'

@tig
Copy link
Collaborator Author

tig commented Jun 13, 2020

This is the (temporary) fix: #687

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StatusBar disappears on resize (smaller)
2 participants