Fix android build somewhat #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walaura
approved these changes
Aug 16, 2019
bump types too magical change to fix the build (until everything is on androidx) fun with xml remove when all deps on android x correct string upgrade deps? set vars for new libs Android Manifest stuff Upgrade more things. update dep? version darts FIX LOCKILE try overriding restore supply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are you doing this?
By facebook/react-native#25325 we should not have been putting assets in ≅src/res/raw and should have been using the equivalent build dir. Thanks to @jordanterry for finding this.
This should also reduce need to do weird things with drawable in makefile.
This gets the build further along but will still need work