Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Use GH's setup-node Action #1062

Merged
merged 1 commit into from
Jan 28, 2022
Merged

chore(ci): Use GH's setup-node Action #1062

merged 1 commit into from
Jan 28, 2022

Conversation

akash1810
Copy link
Member

@akash1810 akash1810 commented Jan 27, 2022

Since actions/setup-node#338, GH's setup-node Action understands .nvmrc files. This makes our guardian/actions-setup-node fork somewhat redundant now.

Move to GH's Action so we can deprecate our fork.

How to test

CI should pass. The build log should also suggest the correct node version is used too.

Since actions/setup-node#338, GH's setup-node Action understands `.nvmrc` files.

This makes our `guardian/actions-setup-node` fork somewhat redundant now.

Move to GH's Action so we can deprecate our fork.
@akash1810 akash1810 requested a review from a team January 27, 2022 12:06
@akash1810
Copy link
Member Author

CI is using node 16.13.0 from our .nvmrc file.

image

@akash1810 akash1810 merged commit 4a8e7d5 into main Jan 28, 2022
@akash1810 akash1810 deleted the aa-setup-node branch January 28, 2022 15:26
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2022

🎉 This PR is included in version 34.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants