Fixes /issues/new map_rotation issue
#269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Kastl <daniel@georepublic.de>
sanak
force-pushed
the
268-creating-an-issue-through-issuesnew-does-not-handle-the-plugin-correctly
branch
from
95e4a0a
to
b5f0c7e
Compare
sanak
changed the title
/issues/new map_rotation issue
2 tasks
sanak
reviewed
May 14, 2024
| && !target.hasChildNodes() | ||
| ) { | ||
| window.createGttClient(target); | ||
| } |
There was a problem hiding this comment.
@smellman (CC: @dkastl)
Related with #257 and PR:#258, I don't know why these changes solve the following error in #268 description.
With this change the map will not initialize correctly when the project change triggers a dynamic loading of content.
So, reviewing these changes is really helpful. 🙇
Adding contentObserver() line caused to generate 2 duplicated maps when clicking on the map, so I don't include the line.
…-not-handle-the-plugin-correctly
dkastl
deleted the
268-creating-an-issue-through-issuesnew-does-not-handle-the-plugin-correctly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #268 .
Changes proposed in this pull request:
@project@dkastl @smellman
I added the followings:
/issues/newdoes not handle the plugin correctly. #268 description.