-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add euclidean option and missing correction to bitwise.dist #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not work at the moment with bitwise.ia. For some reason, it keeps crashing. This has something to do with passing SEXP objects to C code internally, but I'm not sure what is wrong here.
This is not seeming to work. Every time I run it, I get either a crash or a C stack is too close to limit warning. This happens regardless if I pass the Euclid parameter to bitwise diploid or if I attempt to create it within association_index_diploid.
This is documented at the very end of http://adv-r.had.co.nz/C-interface.html#c-vectors These all create R-level objects, so they need to be PROTECT()ed.
This no longer works :(
Something about the shared parallelization was screwing up the code. Unfortunately, I can't for the life of me figure out why since the same process happens with haploids.
It's 10x faster than the old routine
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To aid in the move towards getting genlight objects supported for AMOVA, I've implemented a Euclidean distance option as well as a correction for missing data, which mimics the default distance by
dist()
.The benefit here is that the speed and amount of memory used are greatly reduced with
bitwise.dist()
as compared todist()
due to the fact that it doesn't require conversion to an integer matrix:Created on 2018-04-01 by the reprex package (v0.2.0).
Things that still need to be done
warnings_are_errors
back totrue
in Travis