Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add network proxy configuration settings #96

Merged
merged 2 commits into from
May 26, 2016

Conversation

jongiddy
Copy link

Allow configuration of a network proxy for external calls to network. Adds the ML cluster hostnames to no_proxy to ensure connections work between VirtualBox nodes.

Fixes #82

@grtjn
Copy link
Owner

grtjn commented May 20, 2016

Looks great, thanks. Just wanna check 2 things myself: what happens when you haven't installed proxyconf yet, and what if you did, but omitted those new properties. It will probably work just fine, but just to make sure..

@jongiddy
Copy link
Author

After suggesting in #82 that my fix just needed a guard expression, I forgot to add it. It now works for 3 scenarios:

  1. No proxy set, it ignores the plugin status and extra config.
  2. Proxy set, but plugin not installed, it emits an error message to install the plugin.
  3. Proxy set and plugin installed, it configures the proxy on the hosts.

@grtjn
Copy link
Owner

grtjn commented May 24, 2016

Thanks, looks great!

@grtjn
Copy link
Owner

grtjn commented May 26, 2016

Thanks, works nice the warning!

@grtjn grtjn merged commit 8bba82b into grtjn:master May 26, 2016
@grtjn grtjn added this to the 1.0.2 milestone May 26, 2016
@jongiddy jongiddy deleted the http-proxy-config branch May 31, 2016 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants