s2a: Address comments on PR#11113 #11534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
ejona86
approved these changes
Sep 18, 2024
| @@ -121,6 +121,7 @@ private void checkPeerTrusted(X509Certificate[] chain, boolean isCheckingClientC | |||
| try { | |||
| resp = stub.send(reqBuilder.build()); | |||
| } catch (IOException | InterruptedException e) { | |||
There was a problem hiding this comment.
This catch needs to be split, because we don't want to interrupt on IOException.
There was a problem hiding this comment.
Thanks for pointing that out, done in b060a49
|
Ugh. Sorry, my #11537 is causing a conflict here. |
rmehta19
changed the title
|
@ejona86 , I think you may have to add the kokoro tag to get the rest of tests to run |
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
larry-safran
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
larry-safran
approved these changes
Sep 20, 2024
| @@ -121,6 +121,9 @@ private void checkPeerTrusted(X509Certificate[] chain, boolean isCheckingClientC | |||
| try { | |||
| resp = stub.send(reqBuilder.build()); | |||
| } catch (IOException | InterruptedException e) { | |||
There was a problem hiding this comment.
It would be more standard as the following (but I don't feel strongly about it as it requires the CertificateException definition to be duplicated)
} catch (IOException e) {
Thread.currentThread().interrupt();
throw new CertificateException("Failed to send request to S2A.", e);
} catch (InterruptedException e) {
throw new CertificateException("Failed to send request to S2A.", e);
}
There was a problem hiding this comment.
Thanks Larry, I'll address this in a followup along with #11539 (comment)
larry-safran
added
the
kokoro:run
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.