Change PickFirstLeafLoadBalancer to only have 1 subchannel at a time #11520
Conversation
core/src/main/java/io/grpc/internal/PickFirstLeafLoadBalancer.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/grpc/internal/PickFirstLeafLoadBalancer.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/grpc/internal/PickFirstLeafLoadBalancer.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/grpc/internal/PickFirstLeafLoadBalancer.java
Outdated
Show resolved
Hide resolved
| @@ -458,7 +538,8 @@ private SubchannelData createNewSubchannel(SocketAddress addr, Attributes attrs) | |||
| } | |||
|
|
|||
| private boolean isPassComplete() { | |||
| if (addressIndex.isValid() || subchannels.size() < addressIndex.size()) { | |||
| if ((!serializingRetries && addressIndex.isValid()) | |||
There was a problem hiding this comment.
Why do we want to ignore whether the index is valid?
There was a problem hiding this comment.
Because we reset it for subchannel retry.
There was a problem hiding this comment.
This is still nagging at me. I feel like either we never need this condition or we need to replace it with something else for serializingRetries. I agree that we need this function to return true even though we've reset the index (for ++numTf).
There was a problem hiding this comment.
You're right, there would never be a time where that was true but the subchannels.size() < addressIndex.size() was false. We do have the firstPass variable, so I used that where this is called to skip the comparisons on the repeated checks once we've seen the end.
larry-safran
force-pushed
the
new_pf_prob
branch
2 times, most recently
from
289ca19
to
df8e78c
Compare
core/src/main/java/io/grpc/internal/PickFirstLeafLoadBalancer.java
Outdated
Show resolved
Hide resolved
…if environment variable GRPC_SERIALIZE_RETRIES == true. Cache serializingRetries value so that it doesn't have to look up the flag every time. Clear the correct task when READY in processSubchannelState and move the logic to cancelScheduledTasks Cleanup based on PR review remove unneeded checks for shutdown.
larry-safran
force-pushed
the
new_pf_prob
branch
from
d15a3ee
to
3f910b0
Compare
|
Ready for re-review |
core/src/main/java/io/grpc/internal/PickFirstLeafLoadBalancer.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/grpc/internal/PickFirstLeafLoadBalancer.java
Outdated
Show resolved
Hide resolved
…t is disabled. Remove an extra index.increment in LeafLB Fix spelling, remove unneeded additions
core/src/main/java/io/grpc/internal/PickFirstLeafLoadBalancer.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/grpc/internal/PickFirstLeafLoadBalancer.java
Outdated
Show resolved
Hide resolved
| @@ -458,7 +538,8 @@ private SubchannelData createNewSubchannel(SocketAddress addr, Attributes attrs) | |||
| } | |||
|
|
|||
| private boolean isPassComplete() { | |||
| if (addressIndex.isValid() || subchannels.size() < addressIndex.size()) { | |||
| if ((!serializingRetries && addressIndex.isValid()) | |||
There was a problem hiding this comment.
This is still nagging at me. I feel like either we never need this condition or we need to replace it with something else for serializingRetries. I agree that we need this function to return true even though we've reset the index (for ++numTf).
| } | ||
| } | ||
|
|
||
| if (isPassComplete()) { | ||
| if (!firstPass || isPassComplete()) { |
There was a problem hiding this comment.
Let's at least add a comment that the !firstPass is an optimization.
There was a problem hiding this comment.
Just removed it. Looping on a boolean comparison hopefully won't take too long.
Hide behind environment variable GRPC_SERIALIZE_RETRIES
This is for testing with GMS core to see if they use the new PF with only 1 subchannel at a time trying to reconnect whether that eliminates their 6% data increase.