Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.*: Use strings.ReplaceAll(.....) #7554

Merged
merged 1 commit into from
Aug 26, 2024
Merged

.*: Use strings.ReplaceAll(.....) #7554

merged 1 commit into from
Aug 26, 2024

Conversation

bytetigers
Copy link
Contributor

@bytetigers bytetigers commented Aug 23, 2024

string.ReplaceAll() is equivalent to string.Replace() with a limit of -1

RELEASE NOTES: none

Signed-off-by: bytetigers <bytetiger@icloud.com>
Copy link

linux-foundation-easycla bot commented Aug 23, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.77%. Comparing base (e4b09f1) to head (5e811cc).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7554      +/-   ##
==========================================
- Coverage   81.82%   81.77%   -0.06%     
==========================================
  Files         362      362              
  Lines       27834    27834              
==========================================
- Hits        22776    22761      -15     
- Misses       3850     3858       +8     
- Partials     1208     1215       +7     
Files Coverage Δ
internal/googlecloud/googlecloud.go 76.19% <100.00%> (ø)
internal/xds/bootstrap/template.go 100.00% <100.00%> (ø)

... and 18 files with indirect coverage changes

@purnesh42H purnesh42H self-requested a review August 26, 2024 09:33
@purnesh42H purnesh42H changed the title refactor: use strings.ReplaceAll replace strings.Replace(....., -1) with strings.ReplaceAll(.....) Aug 26, 2024
@purnesh42H purnesh42H changed the title replace strings.Replace(....., -1) with strings.ReplaceAll(.....) Use strings.ReplaceAll(.....) Aug 26, 2024
Copy link
Contributor

@purnesh42H purnesh42H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@purnesh42H
Copy link
Contributor

@arvindbr8 adding you for one more review

@arvindbr8
Copy link
Member

@bytetigers -- Thanks for the PR. I've updated the PR description to talk about the change. Also Mergeable expects a relnote section in every PR description.

@arvindbr8 arvindbr8 changed the title Use strings.ReplaceAll(.....) .*: Use strings.ReplaceAll(.....) Aug 26, 2024
@arvindbr8 arvindbr8 added the Type: Internal Cleanup Refactors, etc label Aug 26, 2024
@arvindbr8 arvindbr8 added this to the 1.67 Release milestone Aug 26, 2024
@arvindbr8 arvindbr8 merged commit a8e6e11 into grpc:master Aug 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants