Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove task allocation in unary call handler #807

Merged
merged 4 commits into from
Mar 6, 2020
Merged

Remove task allocation in unary call handler #807

merged 4 commits into from
Mar 6, 2020

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Mar 5, 2020

Before

          Method |     Mean |     Error |    StdDev |      Op/s | Gen 0/1k Op | Gen 1/1k Op | Gen 2/1k Op | Allocated Memory/Op |
---------------- |---------:|----------:|----------:|----------:|------------:|------------:|------------:|--------------------:|
 HandleCallAsync | 3.395 us | 0.0629 us | 0.0589 us | 294,547.7 |      0.0191 |           - |           - |             1.42 KB |

After

          Method |     Mean |     Error |    StdDev |      Op/s | Gen 0/1k Op | Gen 1/1k Op | Gen 2/1k Op | Allocated Memory/Op |
---------------- |---------:|----------:|----------:|----------:|------------:|------------:|------------:|--------------------:|
 HandleCallAsync | 3.228 us | 0.0390 us | 0.0345 us | 309,742.3 |      0.0153 |           - |           - |             1.35 KB |

@JamesNK JamesNK requested a review from JunTaoLuo March 5, 2020 22:45
@JamesNK JamesNK merged commit 76abb53 into grpc:master Mar 6, 2020
@JamesNK JamesNK deleted the jamesnk/remove-task-allocation branch March 6, 2020 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JunTaoLuo JunTaoLuo JunTaoLuo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamesNK @JunTaoLuo