Optimize client buffers during serialization #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunTaoLuo
approved these changes
Feb 19, 2020
| @@ -112,6 +113,9 @@ public override IBufferWriter<byte> GetBufferWriter() | |||
|
|
|||
| private IBufferWriter<byte> ResolveBufferWriter() | |||
| { | |||
| // TODO(JamesNK): I believe length should be known by the context before the buffer writer is | |||
There was a problem hiding this comment.
I assume we are going to explore this in a future PR. Let's file an issue for it to address all the potential improvements.
JamesNK
force-pushed
the
jamesnk/client-serialization-buffers
branch
from
95df486
to
4fbabea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
The remaining allocations are related to Google.Protobuf creating/working with arrays. Once Google.Protobuf/Grpc.Tools supports buffers the remaining byte array allocations can be removed.