Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OS detection error in UWP #2376

Merged
merged 5 commits into from
Feb 27, 2024
Merged

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Feb 26, 2024

Fixes #2375

RtlGetVersion isn't available in UWP. First check if the app is UWP before calling RtlGetVersion.

src/Grpc.Net.Client/Internal/Native.cs Outdated Show resolved Hide resolved
src/Grpc.Net.Client/Internal/Native.cs Outdated Show resolved Hide resolved
JamesNK and others added 2 commits February 27, 2024 08:09
Co-authored-by: Andrew Casey <amcasey@users.noreply.github.com>
Copy link
Contributor

@amcasey amcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

@JamesNK JamesNK merged commit 098dca8 into grpc:master Feb 27, 2024
5 checks passed
@JamesNK
Copy link
Member Author

JamesNK commented Feb 27, 2024

FYI @tonydnewell an update to OS detection

oguzhand95 referenced this pull request in cerbos/cerbos-sdk-net Apr 1, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [Google.Protobuf](https://github.com/protocolbuffers/protobuf) |
`3.26.0` -> `3.26.1` |
[![age](https://developer.mend.io/api/mc/badges/age/nuget/Google.Protobuf/3.26.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Google.Protobuf/3.26.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Google.Protobuf/3.26.0/3.26.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Google.Protobuf/3.26.0/3.26.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
| [Grpc.Net.Client](https://github.com/grpc/grpc-dotnet) | `2.61.0` ->
`2.62.0` |
[![age](https://developer.mend.io/api/mc/badges/age/nuget/Grpc.Net.Client/2.62.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/nuget/Grpc.Net.Client/2.62.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/nuget/Grpc.Net.Client/2.61.0/2.62.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Grpc.Net.Client/2.61.0/2.62.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>grpc/grpc-dotnet (Grpc.Net.Client)</summary>

###
[`v2.62.0`](https://github.com/grpc/grpc-dotnet/releases/tag/v2.62.0)

##### What's Changed

- Set default streams value in grpc-client.yml by
[@&#8203;sebastienros](https://github.com/sebastienros) in
[https://github.com/grpc/grpc-dotnet/pull/2379](https://github.com/grpc/grpc-dotnet/pull/2379)
- Fix OS detection error in UWP by
[@&#8203;JamesNK](https://github.com/JamesNK) in
[https://github.com/grpc/grpc-dotnet/pull/2376](https://github.com/grpc/grpc-dotnet/pull/2376)
- Update Grpc.Tools version to 2.62 by
[@&#8203;apolcyn](https://github.com/apolcyn) in
[https://github.com/grpc/grpc-dotnet/pull/2382](https://github.com/grpc/grpc-dotnet/pull/2382)
- Bump v2.62.x to pre1 by
[@&#8203;apolcyn](https://github.com/apolcyn) in
[https://github.com/grpc/grpc-dotnet/pull/2383](https://github.com/grpc/grpc-dotnet/pull/2383)
- Bump v2.62.x version for final release by
[@&#8203;apolcyn](https://github.com/apolcyn) in
[https://github.com/grpc/grpc-dotnet/pull/2400](https://github.com/grpc/grpc-dotnet/pull/2400)

**Full Changelog**:
grpc/grpc-dotnet@v2.61.0...v2.62.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/cerbos/cerbos-sdk-net).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't create channel in UWP app in Release mode
2 participants