Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Google.Protobuf to 3.23.1 #2136

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Update Google.Protobuf to 3.23.1 #2136

merged 1 commit into from
Jun 1, 2023

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented May 18, 2023

No description provided.

@JamesNK JamesNK mentioned this pull request May 18, 2023
Closed
@robertodalmonte
Copy link

Hi James,
thanks for answering.

  1. Everything works perfectly unless I publish my wpf application in a single file.
  2. If I do, it works nicely with 3.23.0, it does not with 3.23.1
    I don't have a clue.

Regards

@JamesNK
Copy link
Member Author

JamesNK commented May 19, 2023

Please provide more information, such as the error message, or upload a simple reproduction to a GitHub repository.

@robertodalmonte
Copy link

Hi James,
I was able to create a small solution that shows the problem. Please find it in the following Github repository
https://github.com/robertodalmonte/SolutionProtobuf
If you need it, I can send you my strong key to a private email address.
Regards

@JamesNK JamesNK merged commit ff1a07b into grpc:master Jun 1, 2023
@JamesNK JamesNK deleted the jamesnk/protobuf-3.23.1 branch June 1, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrennanConroy BrennanConroy BrennanConroy approved these changes

@mgravell mgravell Awaiting requested review from mgravell

@ReubenBond ReubenBond Awaiting requested review from ReubenBond

@amcasey amcasey Awaiting requested review from amcasey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JamesNK @robertodalmonte @BrennanConroy