Skip active connections when proxy is configured #1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtattermusch
approved these changes
Aug 30, 2022
There was a problem hiding this comment.
I think the idea is looking good.
- ideally @captainsafia would review as well
- can you please update the PR description with the summary of impact on loadbalancing when proxy is set (what will be the behavior observed by user?).
captainsafia
approved these changes
Aug 30, 2022
| } | ||
|
|
||
| private static HttpHandlerContext CalculateHandlerContext(GrpcChannelOptions channelOptions) | ||
| private static HttpHandlerContext CalculateHandlerContext(Uri address, bool isSecure, GrpcChannelOptions channelOptions) |
There was a problem hiding this comment.
Nit: for consistent ordering of address and isSecure parameters between methods.
Suggested change
| private static HttpHandlerContext CalculateHandlerContext(Uri address, bool isSecure, GrpcChannelOptions channelOptions) | |
| private static HttpHandlerContext CalculateHandlerContext(GrpcChannelOptions channelOptions, Uri address, bool isSecure) |
JamesNK
force-pushed
the
jamesnk/proxy-experiements
branch
from
7ce7ec3
to
19f42bb
Compare
|
Thanks for this, I learnt that Grpc proxy works only when Grpc service is running as HTTPS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1832
tl;dr; HTTPS proxy tunnels a request through another request. This is different from the standard behavior to open a socket. Fallback to passive connectivity when HTTPS proxy tunnel is present.