Validate AddCallCredentials are used by client #1756
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call credentials configured on a non-TLS channel aren't used. Instead, a warning is logged. This is confusing until a dev reads documentation or looks at logs. This behavior was chosen because it's what Grpc.Core does, and compatibility is important.
gRPC client factory has a new
AddCallCredentials
method. This PR updates the client factory to validate that call credentials are used, otherwise, it throws an error. Compatibility with Grpc.Core isn't a problem because gRPC client factory is new for grpc-dotnet.