Resolver has separate error for fetching service config #1475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @captainsafia |
captainsafia
approved these changes
Nov 16, 2021
JamesNK
force-pushed
the
jamesnk/resolver-serviceconfig-error
branch
from
cf9fedb
to
d36707e
Compare
JamesNK
force-pushed
the
jamesnk/resolver-serviceconfig-error
branch
from
d36707e
to
b1156d3
Compare
JamesNK
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address feedback from load balancing proposal. Resolver can resolve a service config as well as addresses. A separate error should be specified to allow fallback behavior when just the service config has an error.