Ensure That Timer Callback Does not Call Method on Disposed Timer #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RIP my free hacktober tshirt 😢. Other than that looks good to me! |
|
@thefringeninja Feel free to take the changes from |
captainsafia
reviewed
Oct 8, 2021
|
@thefringeninja Ditto that! Feel free to incorporate the changes into your original PR. @JamesNK I believe to be officially eligible we have to set the |
|
I don't really want a free t-shirt. I didn't even realize what month it was until after this PR 😀 |
captainsafia
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1444
@thefringeninja - New PR adds locking. I hope you don't mind but I've replaced your PR with this one. Locking issues like this can be subtle and had to explain. Please take a look and double-check that it still fixes the original error.