Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw an error when ConfigureHttpClient is used with gRPC #1257

Merged
merged 2 commits into from
Apr 1, 2021
Merged

Throw an error when ConfigureHttpClient is used with gRPC #1257

merged 2 commits into from
Apr 1, 2021

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Apr 1, 2021

Addresses #1255

@JamesNK JamesNK requested a review from JunTaoLuo April 1, 2021 01:03
@JamesNK JamesNK changed the title Throw an error when ConfigureHttpClient is used with gRPC client factory Throw an error when ConfigureHttpClient is used with gRPC Apr 1, 2021
@JamesNK JamesNK merged commit 57a7ad5 into grpc:master Apr 1, 2021
@JamesNK JamesNK deleted the jamesnk/clientfactory-configurehttpclient branch April 1, 2021 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JunTaoLuo JunTaoLuo JunTaoLuo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamesNK @JunTaoLuo