Support aggressive trimming #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why only 5.0? |
|
grpc-dotnet multi-targets 3.0 and 5.0, and the attributes are only present in .NET 5. When the solution multi-targets again in the future I'll refactor |
|
We added them in source to handle ns2.0 style libraries. Trimming is agnostic of the target so you can do the same here |
|
Could, but why? Everything multi-targets 5.0 so 5.0 packages will always be used in an app with trimming. |
|
You don't have to but trimming isn't coupled to the target framework |
|
Added integration test. Requires a change in Grpc.Core.Api. Blocked while waiting for it to be updated. |
JamesNK
force-pushed
the
jamesnk/trimming
branch
from
9c33eb4
to
fc3c5a8
Compare
JamesNK
force-pushed
the
jamesnk/trimming
branch
from
89321be
to
5b89ace
Compare
JunTaoLuo
approved these changes
Oct 19, 2020
JamesNK
force-pushed
the
jamesnk/trimming
branch
from
5b89ace
to
b6cb0d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attributes to support aggressive trimming. Will add a test app that does trimming soon.