Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add grpc_code label to grpc_server_handling_seconds metric #709

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

miparnisari
Copy link

Changes

Address #606

Mostly copied over from jon-whit/go-grpc-prometheus@b8b0828

Verification

Unit tests pass

@johanbrandhorst
Copy link
Collaborator

Hi, I can see this PR is left as a draft, do you intend to open an issue to discuss the addition of these metrics? I would prefer discussing additions in an issue before reviewing any implementation.

@miparnisari
Copy link
Author

Hey @johanbrandhorst, we can discuss in the issue that already exists? #606

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants