Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support new context API #65

Merged
merged 1 commit into from
Apr 18, 2018
Merged

feat: support new context API #65

merged 1 commit into from
Apr 18, 2018

Conversation

gregberge
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Apr 18, 2018

Codecov Report

Merging #65 into master will decrease coverage by 1.96%.
The diff coverage is 79.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
- Coverage   90.28%   88.32%   -1.97%     
==========================================
  Files          16       16              
  Lines         175      197      +22     
  Branches       41       51      +10     
==========================================
+ Hits          158      174      +16     
- Misses         16       21       +5     
- Partials        1        2       +1
Impacted Files Coverage Δ
src/server/index.js 80.48% <79.59%> (-2.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa3587b...3e056c2. Read the comment docs.

@gregberge
Copy link
Owner Author

@gaearon we should not have to code the function walkTree. There is a similar one in Apollo getDataFromTree. Could you provide a React utility to do that?

@gregberge
Copy link
Owner Author

@gaearon I opened an issue in React facebook/react#12640

@gregberge gregberge merged commit 289ad67 into master Apr 18, 2018
@gregberge gregberge deleted the react-16.3 branch April 18, 2018 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant