Return promise from component.preload() #313
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preface: I'm not sure if this is the "correct" solution to my problem (maybe I missed something in the documentation) but this was the only way I could find to hook into the process that actually loads the component.
Summary
The problem I've been experiencing is that I needed to be able to call
Component.preload()
to load a component, but also wait forpreload()
to complete before rendering the route.(We're stuck using
react-router
3.x
for the time being...)This PR solves our problem by simply returning
ctor. requireAsync(props)
from thepreload()
function, asrequireAsync
already returns a promise that resolves once the component is loaded.Test plan
Where are the tests for
loadable/component
? Am I missing something?