Expand string types for heterogeneous lookups #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Windows, it's almost impossible to avoid using wchar_t, so heterogeneous lookups that support std::wstring/std::wstring_view are pretty good.
|
@fcharlie I have removed some code that your new change made redundant. I don't think it will break anything, but if it does please let me know. |
|
@greg7mdp Very good! I am very glad that you can merge this PR. Deleting the duplicate code does not seem to have any problems at present. I originally wanted to do this, but I am worried about affecting the original code. |
fcharlie
added a commit
to fcharlie/bela
that referenced
this pull request
Jul 10, 2019
…::wstring. see: greg7mdp/parallel-hashmap#15 Thanks Gregory Popovitch accepted my PR
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Windows, it's almost impossible to avoid using wchar_t, so
heterogeneous lookups that support std::wstring/std::wstring_view
are pretty good.