Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong signing key usage #42

Merged
merged 1 commit into from
Nov 6, 2020
Merged

fix wrong signing key usage #42

merged 1 commit into from
Nov 6, 2020

Conversation

nichtsfrei
Copy link
Member

@nichtsfrei nichtsfrei commented Nov 6, 2020

What:

pontos was using signing-key instead of git-signing-key within prepare.

Why:

How:

Checklist:

@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #42 into master will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
+ Coverage   93.11%   93.31%   +0.19%     
==========================================
  Files          26       26              
  Lines        1176     1196      +20     
==========================================
+ Hits         1095     1116      +21     
+ Misses         81       80       -1     
Impacted Files Coverage Δ
pontos/release/release.py 96.11% <ø> (+0.55%) ⬆️
tests/release/test_release.py 98.90% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8de697a...b5032b0. Read the comment docs.

@nichtsfrei nichtsfrei marked this pull request as ready for review November 6, 2020 14:20
@bjoernricks bjoernricks merged commit ff24222 into greenbone:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants