Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling of PROJECT_DEV_VERSION in CMakelists.txt. #32

Merged
merged 6 commits into from
Sep 11, 2020
Merged

Add handling of PROJECT_DEV_VERSION in CMakelists.txt. #32

merged 6 commits into from
Sep 11, 2020

Conversation

nichtsfrei
Copy link
Member

What:

Add handling of PROJECT_DEV_VERSION in CMakelists.txt.

Why:

PROJECT_DEV_VERSION is used within CMakeLists.txt to set the the version to a dev version, which needs to be set to 0 on actual release and 1 on dev versions.

if (PROJECT_DEV_VERSION)
  set (PROJECT_VERSION_SUFFIX "~dev${PROJECT_DEV_VERSION}")
endif (PROJECT_DEV_VERSION)

How:

Create a CMakeLists.txt and ru pontos release, afterwards verify the commit changes.

Checklist:

pontos/version/cmake_version.py Outdated Show resolved Hide resolved
pontos/version/cmake_version.py Outdated Show resolved Hide resolved
nichtsfrei and others added 2 commits September 11, 2020 10:13
@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #32 into master will increase coverage by 0.28%.
The diff coverage is 98.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   92.06%   92.34%   +0.28%     
==========================================
  Files          26       26              
  Lines        1033     1071      +38     
==========================================
+ Hits          951      989      +38     
  Misses         82       82              
Impacted Files Coverage Δ
pontos/version/version.py 71.32% <50.00%> (+0.21%) ⬆️
pontos/release/release.py 92.46% <100.00%> (+0.05%) ⬆️
pontos/version/cmake_version.py 96.33% <100.00%> (+0.98%) ⬆️
tests/version/test_cmake_version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39ae45b...b01bfb2. Read the comment docs.

@y0urself y0urself merged commit 766883e into greenbone:master Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants