This repository has been archived by the owner on Nov 29, 2021. It is now read-only.
Fix target list in get_scan_response. #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
==========================================
+ Coverage 64.36% 64.58% +0.21%
==========================================
Files 4 4
Lines 1131 1138 +7
==========================================
+ Hits 728 735 +7
Misses 403 403
Continue to review full report at Codecov.
|
janowagner
previously approved these changes
Sep 3, 2018
jjnicola
force-pushed
the
fix-get-target
branch
from
2c6197a
to
0ece70a
Compare
Send the target list as received for legacy cases or a comma separeted list in case of multi-target scan.
jjnicola
force-pushed
the
fix-get-target
branch
from
0ece70a
to
02d9460
Compare
jjnicola
force-pushed
the
fix-get-target
branch
from
02d9460
to
aaf01ea
Compare
|
After merging the last PR there was a conflict with this PR. Therefore this one needs a new review. |
janowagner
approved these changes
Sep 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send the target list as received for legacy cases or a comma separated list
in case of multi-target scan.
Add unit test.