Skip to content
This repository has been archived by the owner on Nov 29, 2021. It is now read-only.

Initialize end_time with create_scan #354

Merged
merged 2 commits into from
Jan 26, 2021

Conversation

jjnicola
Copy link
Member

What:
Initialize end_time with create_scan

Why:
Some methods assume end_time is set.
Close issue greenbone/ospd-openvas#361

How:
Set the option scaninfo_store_time and start a scan. Without this patch, the scan crashed.

Checklist:

@codecov
Copy link

codecov bot commented Jan 26, 2021

Codecov Report

Merging #354 (15b5ba6) into ospd-20.08 (60c6166) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           ospd-20.08     #354      +/-   ##
==============================================
+ Coverage       73.90%   73.91%   +0.01%     
==============================================
  Files              23       23              
  Lines            2602     2603       +1     
==============================================
+ Hits             1923     1924       +1     
  Misses            679      679              
Impacted Files Coverage Δ
ospd/scan.py 92.56% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60c6166...15b5ba6. Read the comment docs.

@bjoernricks bjoernricks merged commit 98ebda9 into greenbone:ospd-20.08 Jan 26, 2021
@jjnicola jjnicola deleted the forgotten branch May 26, 2021 10:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants