Skip to content
This repository has been archived by the owner on Nov 29, 2021. It is now read-only.

Add <targets> element to <start_scan>. #34

Merged
merged 4 commits into from
Jul 23, 2018

Conversation

jjnicola
Copy link
Member

It is possible now to specify different ports for different targets,
and run them all from the same task.
Each target, which can be a multi-host target, may have its own port list.
For this reason, get_scan_ports() receive the optional parameter 'target',
to return the corresponding port list for this target. In other case it
returns the port list of the first target for all targets.

For backward compatibility purposes it is still allow to pass a
target list and a port list as attributes, in which case the
element will be ignored. As before, exec_scan is called for each host
and the port list is the same for each host.

Document in start_scan and add example. Document compatibility changes
Add unittest.

Document <targets> in start_scan and add example.
Document compatibility changes
It is possible now to specify different ports for different targets,
and run them all from the same task.
Each target, which can be a multi-host target, may have its own port list.
For this reason, get_scan_ports() receive the optional parameter 'target',
to return the corresponding port list for this target. In other case it
returns the port list of the first target for all targets.

For backward compatibility purposes it is still allow to pass a
target list and a port list as attributes, in which case the <targets>
element will be ignored. As before, exec_scan is called for each host
and the port list is the same for each host.
@jjnicola jjnicola requested a review from a team July 23, 2018 09:19
@codecov
Copy link

codecov bot commented Jul 23, 2018

Codecov Report

Merging #34 into master will increase coverage by 2.62%.
The diff coverage is 58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   60.44%   63.06%   +2.62%     
==========================================
  Files           4        4              
  Lines        1082     1102      +20     
==========================================
+ Hits          654      695      +41     
+ Misses        428      407      -21
Impacted Files Coverage Δ
ospd/misc.py 59.95% <44.44%> (+5.42%) ⬆️
ospd/ospd.py 67.9% <60.97%> (+0.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cf829b...6740212. Read the comment docs.

@janowagner janowagner merged commit e58d3a9 into greenbone:master Jul 23, 2018
@jjnicola jjnicola deleted the ospd-target branch August 7, 2018 11:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants