This repository has been archived by the owner on Nov 29, 2021. It is now read-only.
Do not send all params as scanner prefs #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## ospd-20.08 #305 +/- ##
==============================================
- Coverage 74.69% 73.35% -1.34%
==============================================
Files 23 23
Lines 2545 2560 +15
==============================================
- Hits 1901 1878 -23
- Misses 644 682 +38
Continue to review full report at Codecov.
|
jjnicola
previously approved these changes
Jul 29, 2020
Do not add all params which are in the OSPD_PARAMS dict to the params which are set as preferences.
Documentation about the options we got from the <scanner_params> XML element.
ArnoStiefvater
force-pushed
the
fix-params
branch
from
d5ea9a3
to
93a80a2
Compare
jjnicola
approved these changes
Jul 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not add all params which are in the OSPD_PARAMS dict to the params which are set as scan preferences.
Depends on:
greenbone/ospd-openvas#297