Skip to content
This repository has been archived by the owner on Nov 29, 2021. It is now read-only.

Add attribute to <get_scanner_details> for showing all available parameters #301

Merged
merged 5 commits into from
Jul 23, 2020

Conversation

ArnoStiefvater
Copy link
Member

@ArnoStiefvater ArnoStiefvater commented Jul 17, 2020

  • With attribute list_all set to 1 all available scanner parameters are listed.
  • Per default list_all is considered as 0 and only the parameters visible to the client are shown.
  • This way we do not have to change clients (e.g. gsa) for only showing specific parameters to the user.

Depends on:
greenbone/ospd-openvas#293

@codecov
Copy link

codecov bot commented Jul 20, 2020

Codecov Report

Merging #301 into ospd-20.08 will decrease coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           ospd-20.08     #301      +/-   ##
==============================================
- Coverage       74.69%   74.49%   -0.20%     
==============================================
  Files              23       23              
  Lines            2545     2549       +4     
==============================================
- Hits             1901     1899       -2     
- Misses            644      650       +6     
Impacted Files Coverage Δ
ospd/command/command.py 87.94% <100.00%> (+0.14%) ⬆️
ospd/protocol.py 88.04% <0.00%> (-6.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98d5bb3...a509108. Read the comment docs.

@ArnoStiefvater ArnoStiefvater marked this pull request as ready for review July 20, 2020 08:51
ospd/command/command.py Show resolved Hide resolved
Per default we only get the params visible to the
client and not all supported params.
With list_all we can get all supported params.
@jjnicola jjnicola merged commit 44a2493 into greenbone:ospd-20.08 Jul 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants