Skip to content
This repository has been archived by the owner on Nov 29, 2021. It is now read-only.

Fix stop scan. #204

Merged
merged 3 commits into from
Feb 12, 2020
Merged

Fix stop scan. #204

merged 3 commits into from
Feb 12, 2020

Conversation

jjnicola
Copy link
Member

Wait for the scan process to be stopped before delete it from the process table.

@codecov
Copy link

codecov bot commented Feb 12, 2020

Codecov Report

Merging #204 into master will increase coverage by 0.02%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
+ Coverage   72.64%   72.66%   +0.02%     
==========================================
  Files          16       16              
  Lines        2058     2067       +9     
==========================================
+ Hits         1495     1502       +7     
- Misses        563      565       +2
Impacted Files Coverage Δ
ospd/ospd.py 74.59% <100%> (+0.16%) ⬆️
ospd/command/command.py 89.01% <60%> (-0.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67b0747...354baa8. Read the comment docs.

Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like busy waiting which will waste a loot of cpu power. Wouldn't it be possible to wait for the process to be finished?

CHANGELOG.md Outdated
@@ -18,6 +18,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
- Update daemon start sequence. Run daemon.check before daemon.init now. [#197](https://github.com/greenbone/ospd/pull/197)
- Improve get_vts cmd response, sending the vts piece by piece.[#201](https://github.com/greenbone/ospd/pull/201)

### Fix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Fix
### Fixed

@jjnicola jjnicola merged commit 8945f94 into greenbone:master Feb 12, 2020
@jjnicola jjnicola deleted the stop-race branch February 12, 2020 13:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants