This repository has been archived by the owner on Nov 29, 2021. It is now read-only.
Create data manager and spawn new process to keep the vts dictionary. #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new process is spawn, and it will load the vts in a dictionary. This process run and keep the collection. The main process it is lighter now. Therefore, the new fork()'ed scan processes inherite less memory.
Also check for None before iterating.
Codecov Report
@@ Coverage Diff @@
## master #191 +/- ##
==========================================
+ Coverage 68.38% 68.45% +0.06%
==========================================
Files 12 12
Lines 1838 1842 +4
==========================================
+ Hits 1257 1261 +4
Misses 581 581
Continue to review full report at Codecov.
|
bjoernricks
previously approved these changes
Dec 6, 2019
DictProxy in Python 3.5 does not support iteration as over a regular dict.
jjnicola
requested review from
bjoernricks
and removed request for
bjoernricks
bjoernricks
suggested changes
Dec 9, 2019
Co-Authored-By: Björn Ricks <bjoern.ricks@gmail.com>
bjoernricks
approved these changes
Dec 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new process is spawn, and it will load the vts in a dictionary.
This process run and keep the collection.
The main process it is lighter now. Therefore, the new fork()'ed scan
processes inherit less memory.