This repository has been archived by the owner on Nov 29, 2021. It is now read-only.
Add element "vts" to parameters for starting scans #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
==========================================
- Coverage 55.74% 55.72% -0.03%
==========================================
Files 4 4
Lines 1044 1048 +4
==========================================
+ Hits 582 584 +2
- Misses 462 464 +2
Continue to review full report at Codecov.
|
jjnicola
reviewed
Jun 15, 2018
ospd/ospd.py
Outdated
| for name, param in BASE_SCANNER_PARAMS.items(): | ||
| self.add_scanner_param(name, param) | ||
| self.vts = dict() | ||
| self.vt_id_pattern = re.compile("[0-9a-zA-Z_:.]{1,80}") |
There was a problem hiding this comment.
I would add the dash symbol - to the list of possible characters in the vt_id.
The element "vts" is added to the base scanner parameters and allows to send a list of vt's to be executed by the scanner. The scanner needs to parse and handle the list on its own. Since "vts" is a comma-separated list of vt_ids, to prevent parsing/escaping problems, the syntax of a vt_id is now limited to certain characters which are typically used for ids.
jjnicola
approved these changes
Jun 18, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The element "vts" is added to the base scanner parameters
and allows to send a list of vt's to be executed by the scanner.
The scanner needs to parse and handle the list on its own.
Since "vts" is a comma-separated list of vt_ids, to prevent
parsing/escaping problems, the syntax of a vt_id is now
limited to certain characters which are typically used for ids.