This repository has been archived by the owner on Nov 29, 2021. It is now read-only.
Allow clients to choose TLS versions > 1.0 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows OSP clients to negotiate a TLS version higher than TLSv1.0 instead of forcing them to use this specific protocol version which may be subject to protocol-specific weaknesses depending on the environment. As the comment explains, the constant `ssl.PROTOCOL_SSLv23` does indeed select the highest protocol version that both the client and server support for current Python versions (>= 3.4), despite its name. If compatibility with Python 3.4 is no longer desired, the slightly more fitting constant `ssl.PROTOCOL_TLS` should be used.
jjnicola
approved these changes
Jun 15, 2018
janowagner
approved these changes
Jun 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows OSP clients to negotiate a TLS version higher than
TLSv1.0 instead of forcing them to use this specific protocol version
which may be subject to protocol-specific weaknesses depending on the
environment.
As the comment explains, the constant
ssl.PROTOCOL_SSLv23does indeedselect the highest protocol version that both the client and server
support for current Python versions (>= 3.4), despite its name.
If compatibility with Python 3.4 is no longer desired, the slightly more
fitting constant
ssl.PROTOCOL_TLSshould be used.