This repository has been archived by the owner on Nov 29, 2021. It is now read-only.
[2.0] Check the existence and status of an scan_id #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## ospd-2.0 #179 +/- ##
============================================
- Coverage 68.53% 68.46% -0.07%
============================================
Files 12 12
Lines 1802 1814 +12
============================================
+ Hits 1235 1242 +7
- Misses 567 572 +5
Continue to review full report at Codecov.
|
bjoernricks
suggested changes
Nov 8, 2019
ospd/ospd.py
Outdated
| @@ -1707,9 +1713,20 @@ def create_scan(self, scan_id, targets, options, vts): | |||
|
|
|||
| @return: New scan's ID. | |||
There was a problem hiding this comment.
The docstring should be updated for the already running case. It is returning None implicitly.
It checked only for STOPPED before resuming a scan. It checks now also for FINISHED and RUNNING status and avoid to restartin a scan which is already running or finished.
jjnicola
force-pushed
the
check-status-2
branch
from
9453b2b
to
30a3398
Compare
bjoernricks
approved these changes
Nov 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.