This repository has been archived by the owner on Nov 29, 2021. It is now read-only.
[2.0] Extend OSP with finished_hosts subelement of target #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps to differentiate the finished from the exclude hosts, since both are excluded but the finished hosts must be considered for calculation of the scan progress.
This improves the calculation of the scan progress specially for resumed scans.
Codecov Report
@@ Coverage Diff @@
## ospd-2.0 #177 +/- ##
===========================================
- Coverage 68.63% 68.53% -0.1%
===========================================
Files 12 12
Lines 1779 1802 +23
===========================================
+ Hits 1221 1235 +14
- Misses 558 567 +9
Continue to review full report at Codecov.
|
bjoernricks
suggested changes
Nov 7, 2019
bjoernricks
approved these changes
Nov 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.