Skip to content
This repository has been archived by the owner on Nov 29, 2021. It is now read-only.

Add support to handle multiple requests simultaneously. #136

Merged
merged 4 commits into from
Sep 27, 2019

Conversation

jjnicola
Copy link
Member

OSPD can now answer to multiple clients in parallel without a waiting time.
Before, if a client did a request, it should wait until the response to a
first request had been completely sent.

Basically, it replace the bind and select methods from socket module with
a start method which uses instead socketserver and threading modules.

mattmundell
mattmundell previously approved these changes Sep 25, 2019
Copy link

@mattmundell mattmundell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't checked code, but this is a good change, and it works for me.

OSPD can now answer to multiple clients in parallel without a waiting time.
Before, if a client did a request, it should wait until the response to a
first request had been completely sent.

Basically, it replace the bind and select methods from socket module with
a start method which uses instead socketserver and threading modules.
Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The if tls_ctx branches are always a sign for necessary refactoring. I would go for merging this request and doing some cleanup afterwards.

@bjoernricks bjoernricks merged commit 47acd97 into greenbone:master Sep 27, 2019
@jjnicola jjnicola deleted the multiclient-listener branch September 27, 2019 09:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants