This repository has been archived by the owner on Nov 29, 2021. It is now read-only.
Add method to check if a target finished cleanly or crashed. #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some scans can finish cleanly even if the don't scan all the hosts in the target string. This produced to have an ended scan with a incomplete progress scan percentage (< 100%), which was treated as an error. Now this function allow to do a check and to decide if it is an error or the scan finished cleanly.
Codecov Report
@@ Coverage Diff @@
## master #133 +/- ##
==========================================
- Coverage 68.85% 68.71% -0.15%
==========================================
Files 12 12
Lines 1737 1742 +5
==========================================
+ Hits 1196 1197 +1
- Misses 541 545 +4
Continue to review full report at Codecov.
|
bjoernricks
approved these changes
Sep 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some scans can finish cleanly even if the don't scan all the hosts in the target string.
This produced to have an ended scan with a incomplete progress scan percentage (< 100%), which was treated as an error. Now this function allow to do a check and to decide if it is an error or the scan finished cleanly.