This repository has been archived by the owner on Nov 29, 2021. It is now read-only.
Improve handling of stopped tasks #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not call stop_scan if the task was already set as stopped.
Because the "Stop scan" is not added as result anymore.
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
=========================================
- Coverage 68.66% 68.46% -0.2%
=========================================
Files 12 12
Lines 1704 1703 -1
=========================================
- Hits 1170 1166 -4
- Misses 534 537 +3
Continue to review full report at Codecov.
|
bjoernricks
approved these changes
Aug 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not call stop_scan if the task was already set as stopped and remove senseless log results.