This repository has been archived by the owner on Nov 29, 2021. It is now read-only.
Create pid file to avoid having two daemons. #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the --pid-file option in the parser. Add method to create and remove the pid file. Set the signal handler and atexit to remove the pid file when the daemon finishes.
Codecov Report
@@ Coverage Diff @@
## master #126 +/- ##
=========================================
- Coverage 69.67% 68.78% -0.9%
=========================================
Files 12 12
Lines 1672 1701 +29
=========================================
+ Hits 1165 1170 +5
- Misses 507 531 +24
Continue to review full report at Codecov.
|
bjoernricks
suggested changes
Aug 14, 2019
ospd/misc.py
Outdated
|
|
||
| pid = str(os.getpid()) | ||
|
|
||
| if os.path.isfile(pidfile): |
There was a problem hiding this comment.
Please use pathlib instead
Suggested change
| if os.path.isfile(pidfile): | |
| if Path(pidfile).is_file(): |
ospd/misc.py
Outdated
|
|
||
| def remove_pidfile(pidfile, signum=None, frame=None): | ||
| """ Removes the pidfile before ending the daemon. """ | ||
| if os.path.isfile(pidfile): |
There was a problem hiding this comment.
Please use the pathlib here too. Maybe it is even better to already pass pidfile as a Path object to the functions but i am not 100% sure about that.
ospd/misc.py
Outdated
| """ Removes the pidfile before ending the daemon. """ | ||
| if os.path.isfile(pidfile): | ||
| LOGGER.debug("Finishing daemon process") | ||
| os.remove(pidfile) |
There was a problem hiding this comment.
Should be done via a Path instance
pidpath = Path(pidfile)
if pidfile.is_file():
...
pidfile.unlink()Now the pid in the pid file is the right one. Also initialize the daemon after going to background, to not hang in the console during initialization.
|
Thank you @bjoernricks ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the --pid-file option in the parser.
Add method to create and remove the pid file.
Set the signal handler and atexit to remove the pid file when the daemon finishes.
How to:
by default, the pid path is /run/ospd/ospd.py. You will have to create the directory and set the right permissions.
Or you can run ospd-daemon with the option --pid-file and use an existing directory with rw permissions:
This is also valid to do it with the config file, adding under the right section the option. E.g.: