Skip to content
This repository has been archived by the owner on Nov 29, 2021. It is now read-only.

Use ordered dictionary to maintain the results order #119

Merged
merged 2 commits into from
Jul 24, 2019

Conversation

jjnicola
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jul 19, 2019

Codecov Report

Merging #119 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #119      +/-   ##
=========================================
+ Coverage   70.28%   70.3%   +0.01%     
=========================================
  Files          11      11              
  Lines        1639    1640       +1     
=========================================
+ Hits         1152    1153       +1     
  Misses        487     487
Impacted Files Coverage Δ
ospd/misc.py 81.28% <100%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d2395a...e954375. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 19, 2019

Codecov Report

Merging #119 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #119      +/-   ##
=========================================
+ Coverage   70.28%   70.3%   +0.01%     
=========================================
  Files          11      11              
  Lines        1639    1640       +1     
=========================================
+ Hits         1152    1153       +1     
  Misses        487     487
Impacted Files Coverage Δ
ospd/misc.py 81.28% <100%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d2395a...df9fd73. Read the comment docs.

bjoernricks
bjoernricks previously approved these changes Jul 21, 2019
Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to add a test for this expected behavior too!

Btw. this is only an issue with python 3.5. In python 3.6 the insertion order of dicts is kept which got an official spec with python 3.7 too. https://mail.python.org/pipermail/python-dev/2017-December/151283.html

@jjnicola jjnicola merged commit fedb21c into greenbone:master Jul 24, 2019
@jjnicola jjnicola deleted the results-dict branch August 21, 2019 06:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants