Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add details parameter to get_vt_iterator() #215

Merged
merged 4 commits into from
Mar 10, 2020

Conversation

jjnicola
Copy link
Member

If details is True, it adds the vt dependencies as subelement
with the oid. For this an expensive query to redis is necessary.
The query takes about 3 seconds, which is especially expensive when
only one vt must be sent.
Otherwise, the dependencies are added as subelement of custom, the query
will not be perfomed, and quicker response is given for a single vt.

Depends on PR greenbone/ospd#222

If details is True, it adds the vt dependencies as subelement
with the oid. For this an expensive query to redis is necessary.
The query takes about 3 seconds, which is especially expensive when
only one vt must be sent.
Otherwise, the dependencies are added as subelement of custom, the query
will not be perfomed, and quicker response is given for a single vt.
@jjnicola
Copy link
Member Author

It needs a Pipfile.lock update, after greenbone/ospd#222 is merged

@codecov
Copy link

codecov bot commented Mar 10, 2020

Codecov Report

Merging #215 into master will increase coverage by 0.01%.
The diff coverage is 30.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #215      +/-   ##
==========================================
+ Coverage   76.12%   76.14%   +0.01%     
==========================================
  Files           6        6              
  Lines        1332     1333       +1     
==========================================
+ Hits         1014     1015       +1     
  Misses        318      318
Impacted Files Coverage Δ
ospd_openvas/daemon.py 62.02% <30.76%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22fae66...5ceee6f. Read the comment docs.

@jjnicola jjnicola marked this pull request as ready for review March 10, 2020 10:35
@jjnicola jjnicola merged commit 3b6a157 into greenbone:master Mar 10, 2020
@jjnicola jjnicola deleted the vt-details branch March 10, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants