Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pkgconfig for gnutls #30

Merged
merged 5 commits into from
Feb 15, 2021
Merged

Conversation

tuxmaster5000
Copy link
Contributor

Fix #29

@tuxmaster5000 tuxmaster5000 requested a review from a team February 9, 2021 08:39
@jjnicola
Copy link
Member

Hi @tuxmaster5000,
Does it work for you? It does not pass the CI tests. I have tested this PR in my local dev environment and it is broken as well.

@tuxmaster5000
Copy link
Contributor Author

Yes,it will work on my side, but I use CentOS as the build OS. Can you modify the test, so that the whole compile call are visible?
On my build at that stage there is no '-R' option used:

[ 91%] Linking C executable winexe
cd /builddir/build/BUILD/openvas-smb-1.0.5/winexe && /usr/bin/cmake3 -E cmake_link_script CMakeFiles/winexe.dir/link.txt --verbose=1
/usr/lib64/ccache/cc -Wno-unused-result -fno-strict-aliasing -fPIC -O2 -D_FORTIFY_SOURCE=2 -fstack-protector -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1  -m64 -mtune=generic  -Wl,-z,relro -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -rdynamic CMakeFiles/winexe.dir/winexe.c.o CMakeFiles/winexe.dir/service.c.o CMakeFiles/winexe.dir/async.c.o CMakeFiles/winexe.dir/winexesvc_exe.c.o  -o winexe  ../samba/libsamba-static.a -ldl -lgnutls -lpopt -Wl,-z,relro -Wl,-z,now -L/usr/lib64/heimdal -lkrb5 -lgssapi -lasn1 -lcom_err -pthread -L/usr/lib64/gvm-helper -lgnutls -ltspi -latomic -lhogweed -lgmp -ltasn1 -lidn2 -lunistring -lnettle -lhdb 

@jjnicola
Copy link
Member

We will update the image used for running the tests, as it is currently based on stretch, but it should be buster.
It finally worked in my local env, I just was missing a dependency for gnutls version I have installed in my Debian. I have not seen the "-R" issue either.

samba/CMakeLists.txt Outdated Show resolved Hide resolved
Yes,sorry for the fat fingers :)

Co-authored-by: cfi-gb <34644702+cfi-gb@users.noreply.github.com>
@jjnicola
Copy link
Member

Hi @tuxmaster5000,

could you add Changlog entry? after your commit, the test will run again, using the new docker images. This time, all check should pass without problems.

You can check the Changelog format here

@tuxmaster5000
Copy link
Contributor Author

Now the change log entry was added.

@bjoernricks bjoernricks merged commit f2c8e1e into greenbone:master Feb 15, 2021
@tuxmaster5000 tuxmaster5000 deleted the pkgconfig branch February 15, 2021 10:52
@jjnicola jjnicola mentioned this pull request Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.0.5] gnutls cmake pkgconfig results are not used
4 participants