Added retry of sensor connection for performance reports on failure. #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In manage.c in function get_osp_performance_string (..): The installation of the connection to the sensor via osp_connect_with_data (..) and the access to the performance data via osp_get_performance_ext (..) are now retried several times on failure.
jhelmold
added
backport-to-oldstable
timopollmeier
requested changes
Jul 19, 2021
in manage.c, in function get_osp_performance_string(..): Moved the declaration of the variable "return_value" to the top of the function.
In manage.c, in function get_osp_performance_string (..): Replaced the assignment of value "connection_retry = SCANNER_CONNECTION_RETRY_DEFAULT;" by "connection_retry = get_scanner_connection_retry();".
In manage.c in function get_osp_performance_string (..): Amended the formatting of a while statement and the calls of get_scanner_connection_retry ().
In manage.c, in function get_osp_performance_string (..): Rebuild the logic of the connection retries for osp_connect_with_data (..) and osp_get_performance_ext (..) slightly.
timopollmeier
approved these changes
Jul 19, 2021
This was referenced Jul 19, 2021
timopollmeier
added a commit
that referenced
this pull request
Jul 19, 2021
Added retry of sensor connection for performance reports on failure. (backport #1633)
timopollmeier
added a commit
that referenced
this pull request
Jul 19, 2021
Added retry of sensor connection for performance reports on failure. (backport #1633)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added retry of sensor connection for performance reports on failure.
What
In manage.c in function get_osp_performance_string (..):
The installation of the connection to the sensor via
osp_connect_with_data (..) and the access to the
performance data via osp_get_performance_ext (..) are
now retried several times on failure.
AP-1479
Why:
This fixes a bug.
How did you test it:
Ran the report that uses the connection several times.
Checklist: