-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The alterable indicator is now copied when cloning a task. #1553
The alterable indicator is now copied when cloning a task. #1553
Conversation
in gmp.c: Introduced the new value "-1" for the parameter "alterable" at the function call of "copy_task()" in function "gmp_xml_handle_end_element()". in manage_sql.c, function "copy_task()": Extended the call of the function "copy_resource_lock ()", so that also the column "alterable" is copied. The column "alterable" of the table "tasks" is now only updated if the parameter "alterable" is >= 0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice if you could add the meaning of the -1 value for the alterable
parameter to the function documentation.
Also, please add the backport labels to PRs that are meant to be backported.
Adjusted the comment for the parameter "alterable" at the function header of copy_task() in manage_sql.c.
…nto alterable_task_for_clone
@Mergifyio refresh |
Command
|
@Mergifyio backport gvmd-21.04 |
@Mergifyio backport gvmd-20.08 |
Command
|
Command
|
The alterable indicator is now copied when cloning a task.
What:
in gmp.c:
Introduced the new value "-1" for the parameter "alterable"
at the function call of "copy_task()" in function
"gmp_xml_handle_end_element()".
in manage_sql.c, function "copy_task()":
Extended the call of the function "copy_resource_lock ()",
so that also the column "alterable" is copied. The column
"alterable" of the table "tasks" is now only updated if
the parameter "alterable" is >= 0.
Why:
This fixes a bug.
How did you test it:
Checked the cloning of audits and tasks in GSA.
Checklist: