Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show empty scores in SecInfo where appropriate #1457

Merged
merged 2 commits into from
Mar 22, 2021

Conversation

timopollmeier
Copy link
Member

@timopollmeier timopollmeier commented Mar 19, 2021

What:
CPEs, OVAL definitions and CERT advisories that do not have any severity
info because they have no CVE references will have an empty score in
the GMP response instead of score 0.

Why:
This is more consistent with the filtering and aggregates, where 0
and no score are also distinguished.

How did you test it:
By getting lists of CPE etc. with and without a severity="" filter and
checking the score elements in the responses.

Checklist:

CPEs, OVAL definitions and CERT advisories that do not have any severity
info because they have no CVE references will have an empty score in
the GMP response instead of score 0.

This is more consistent with the filtering and aggregates, where 0
and no score are also distinguished.
@timopollmeier timopollmeier added the backport-to-main This pull request will be ported to the master branch label Mar 19, 2021
@timopollmeier timopollmeier marked this pull request as ready for review March 19, 2021 13:43
@timopollmeier timopollmeier requested a review from a team as a code owner March 19, 2021 13:43
@nichtsfrei nichtsfrei merged commit c455f7e into greenbone:gvmd-21.04 Mar 22, 2021
timopollmeier added a commit that referenced this pull request Mar 22, 2021
Show empty scores in SecInfo where appropriate (bp #1457)
@timopollmeier timopollmeier deleted the empty-secinfo-scores branch October 15, 2021 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-main This pull request will be ported to the master branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants